fix: After coming back from result detail, search result come back to the top, not current position #1150 #1183
Conversation
| .setPopExitAnim(R.anim.slide_out_right) | ||
| .setPopUpTo(R.id.eventsFragment, true) | ||
| .build() | ||
| Navigation.findNavController(rootView).navigate(R.id.eventsFragment, bundle, navOptions) |
There was a problem hiding this comment.
Not a good solution. It was better earlier. Can you please find another way for it? Reset looks good.
There was a problem hiding this comment.
@liveHarshit I have updated a better solution. haha, I was stupid before, this is actually a much simpler issue.
Details: After coming from EventDetailsFragment, the SearchResultFragment doesn't retain the old position. Adding id for NestedScrollView will make Android automatically retain the current position Fixes: #1150
| @@ -29,6 +29,7 @@ | |||
| </LinearLayout> | |||
|
|
|||
| <androidx.core.widget.NestedScrollView | |||
| android:id="@+id/searchResultsNestedScrollView" | |||
There was a problem hiding this comment.
Can you please explain, how defining an id solve the issue?
There was a problem hiding this comment.
@liveHarshit Well, in short, this is Android View State Storing Mechanism (to retain an amount of information/state if we provide it an id). So for instance, if you're having an EditText and some text in it, I believe the text is also retained after screen rotation if we provide it with an id.
So this is also the way current EventsFragment restoring its position after coming back from EventDetailsFragment.
Details:
After coming from EventDetailsFragment, the SearchResultFragment doesn't retain the old position. Adding id for NestedScrollView will make Android automatically retain the current position
Fixes: #1150